Skip to content

Fix fully qualified alias heads in nested defmodule - #16144

Merged
josevalim merged 1 commit into
elixir-lang:mainfrom
lukaszsamson:codex/fix-qualified-defmodule-alias-head
Nov 18, 2026
Merged

josevalim merged 1 commit into
elixir-lang:mainfrom
lukaszsamson:codex/fix-qualified-defmodule-alias-head

Conversation

@lukaszsamson

Copy link
Copy Markdown
Contributor

defmodule unquote(__MODULE__).Inner works at the top level but fails inside a module body with invalid value for option :as. The compiler prepends Elixir. to the already qualified alias head.

defmodule DM do
  defmacro define_inner do
    quote do
      defmodule unquote(__MODULE__).Inner do
        def value, do: :ok
      end
    end
  end
end

require DM
DM.define_inner() # works

defmodule Caller do
  require DM
  DM.define_inner() # fails before the fix
end

Treat qualified atom heads like explicit Elixir.* names. Both calls define DM.Inner and preserve the caller’s aliases.

Assisted-by: Codex:gpt-6.2-sol

@josevalim
josevalim merged commit c34d1d6 into elixir-lang:main Nov 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants